Initial commit for introducing the SONiC Platform Development Environ… #3778
Conversation
…ment (PDE) into sonic-buildimage
|
retest this please |
| src/sonic-platform-pde \ | ||
| src/sonic-ztp | ||
|
|
||
| .PHONY: sonic-slave-build sonic-slave-bash init initpde reset |
There was a problem hiding this comment.
We need to be able to build a minimal subset of SONiC with the PDE docker enabled. We can either handle this as part of make init (or in this case make initpde), or we would have to modify slave.mk to ignore NON-PDE required build targets. In this case, we think its easier to maintain a list of essential submodules for the PDE and make it part of the "make initpde" step for doing a build. Can we leave this change as it is or do yo have an alternative suggestion?
We automate the PDE build internally by doing the following.
make initpde
make configure PLATFORM=broadcom
make target/sonic-broadcom-pde.bin
There was a problem hiding this comment.
There was a problem hiding this comment.
@lguohan, @jleveque - can you please address these responses from Bill (following comments also)? We have come up with a way of doing a minimal build for PDE (reduced build time etc), but it seems that you didn't like this. Do you have an alternative in mind? Thanks.
@lguohan, @jleveque - I never heard back. Should I setup a call to discuss?
There was a problem hiding this comment.
We need to run this "make initpde" to differentiate the Full SONIC image build. Actually, ODM will not run this step, since the step is done by BRCM internally to generate the light weight PDE repo for ODM. Another reason for this is to protect the BRCM SONIC changes with just platform related common change exposing to ODM when working with ODM on ODM HWQ projects.
For PDE, we also have another option which is to run PDE as a docker in Full SONIC image. In the FULL sonic image runtime, we can launch PDE by pde.sh script. The script will disable most dockers in SONIC image and just reserve the necessary dockers with a lightweight environment for ODM platform testing. By default, the PDE docker will not be triggered in Full SONIC image.
Geans
make initpde
make configure PLATFORM=broadcom
make target/sonic-broadcom-pde.bin
platform/broadcom/one-pde-image.mk
Outdated
| $(SONIC_ONE_PDE_IMAGE)_IMAGE_TYPE = onie | ||
| $(SONIC_ONE_PDE_IMAGE)_INSTALLS += $(BRCM_OPENNSL_KERNEL) | ||
| $(SONIC_ONE_PDE_IMAGE)_INSTALLS += $(PDDF_PLATFORM_MODULE) | ||
| $(SONIC_ONE_PDE_IMAGE)_LAZY_INSTALLS += $(DELL_S6000_PLATFORM_MODULE) \ |
There was a problem hiding this comment.
this is duplicate module in one-image.mk
| DEBUG_IMG="$(INSTALL_DEBUG_TOOLS)" \ | ||
| DEBUG_SRC_ARCHIVE_FILE="$(DBG_SRC_ARCHIVE_FILE)" \ | ||
| USERNAME="$(USERNAME)" \ | ||
| PASSWORD="$(PASSWORD)" \ | ||
| BUILD_TARGET="$@" \ |
There was a problem hiding this comment.
I do not this BUILD_TARGET used anyway. is there something else missing?
There was a problem hiding this comment.
We pass the BUILD_TARGET to the docker build slave so we can support the build target sonic-broadcom-pde.bin to differenciate it from the normal build. Please let me know if there is a better way to handle this.
|
Please see build tools pull request for PDE |
| nodaemon=true | ||
|
|
||
| [program:rsyslogd] | ||
| command=/usr/sbin/rsyslogd -n -iNONE" |
| @@ -216,7 +218,18 @@ SONIC_BUILD_INSTRUCTION := make \ | |||
| ENABLE_SYNCHRONOUS_MODE=$(ENABLE_SYNCHRONOUS_MODE) \ | |||
| $(SONIC_OVERRIDE_BUILD_VARS) | |||
|
|
|||
| .PHONY: sonic-slave-build sonic-slave-bash init reset | |||
| PDESUBMODULES = src/sonic-linux-kernel \ | |||
There was a problem hiding this comment.
i do not think this is needed.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3778 in repo Azure/sonic-buildimage |
|
@geans-pin , wbschwar (PR author) can rerun it by command "/azpw run". |
|
/azp run |
|
Pull request contains merge conflicts. |
I think we will need to resubmit this PR |
|
Original submitter has left, pls close this code PR. Updated Code PR is tracked under #7510 |
|
Closing in favor of #7510 |
What I did
This PR is for the build infrastructure changes to support the PDE (platform development environment). For additional detail see:
sonic-net/SONiC#407
How I did it
The PDE silicon test harness and platform test harness can be found in
src/sonic-platform-pdk-pde
How to verify it
You must have both this PR and PR below.
Azure/sonic-platform-pdk-pde#28
Enable PDE by un-commenting line in rules/config
ENABLE_PDE=y
build PDE enabled SONiC install image
make target/sonic-$MACHINE-pde.bin
Currently only Broadcom support has been added.
Description for the changelog
Adding support for Platform Development Environment (PDE)
A picture of a cute animal (not mandatory but encouraged)